Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace requirement files with pyproject #6116

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Replace requirement files with pyproject #6116

merged 1 commit into from
Sep 25, 2023

Conversation

dafeda
Copy link
Contributor

@dafeda dafeda commented Sep 20, 2023 •
edited
Loading

Pre review checklist

  • Read through the code changes carefully after finishing work
  • Make sure tests pass locally (after every commit!)
  • Prepare changes in small commits for more convenient review (optional)
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Updated documentation
  • Ensured that unit tests are added for all new behavior (See
    Ground Rules),
    and changes to existing code have good test coverage.

Pre merge checklist

  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.

@dafeda dafeda changed the title Pyproject Move some settings from setup to pyproject Sep 20, 2023
@dafeda dafeda self-assigned this Sep 20, 2023
@dafeda dafeda added the release-notes:skip If there should be no mention of this in release notes label Sep 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #6116 (46214a7) into main (1017487) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6116      +/-   ##
==========================================
+ Coverage   82.45%   82.46%   +0.01%     
==========================================
  Files         350      350              
  Lines       21423    21423              
  Branches      839      839              
==========================================
+ Hits        17664    17667       +3     
+ Misses       3461     3458       -3     
  Partials      298      298
Files Changed Coverage Δ
src/ert/dark_storage/endpoints/responses.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dafeda dafeda closed this Sep 20, 2023
@dafeda dafeda reopened this Sep 20, 2023
@dafeda dafeda force-pushed the pyproject branch 8 times, most recently from 2815c66 to 846e582 Compare September 21, 2023 05:01
@dafeda dafeda changed the title Move some settings from setup to pyproject Replace requirement files with pyproject Sep 21, 2023
@dafeda dafeda added the maintenance Not a bug now but could be one day, repaying technical debt label Sep 21, 2023
@dafeda dafeda requested a review from berland September 21, 2023 05:33
berland
berland reviewed Sep 21, 2023
View reviewed changes
.github/workflows/style.yml
@@ -32,11 +32,10 @@ jobs:
cache-dependency-path: |
setup.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line was removed further up, it should not be removed here?

@dafeda dafeda force-pushed the pyproject branch 4 times, most recently from 4e91d7c to f414991 Compare September 22, 2023 12:07
frode-aarstad
frode-aarstad approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@frode-aarstad frode-aarstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dafeda dafeda merged commit 6755fc6 into equinor:main Sep 25, 2023
38 checks passed
@dafeda dafeda deleted the pyproject branch September 25, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berland berland berland left review comments

@frode-aarstad frode-aarstad frode-aarstad approved these changes

Assignees

@dafeda dafeda

Labels
maintenance Not a bug now but could be one day, repaying technical debt release-notes:skip If there should be no mention of this in release notes
Projects
SCOUT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dafeda @codecov-commenter @berland @frode-aarstad